Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC k8s plugin start entrypoint #5400

Merged
merged 2 commits into from
Dec 10, 2024
Merged

PoC k8s plugin start entrypoint #5400

merged 2 commits into from
Dec 10, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Dec 10, 2024

What this PR does:

as title

Why we need it:

to invoke the k8s plugin from pipedv1

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@t-kikuc t-kikuc enabled auto-merge (squash) December 10, 2024 02:13
@t-kikuc t-kikuc merged commit 4f1ff0f into master Dec 10, 2024
14 of 16 checks passed
@t-kikuc t-kikuc deleted the k8s-plugin-initialize branch December 10, 2024 02:13
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 25.73%. Comparing base (5cbd306) to head (bfb908a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/kubernetes/server.go 0.00% 37 Missing ⚠️
pkg/configv1/piped.go 0.00% 9 Missing ⚠️
...app/pipedv1/plugin/kubernetes/deployment/server.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5400      +/-   ##
==========================================
- Coverage   25.75%   25.73%   -0.02%     
==========================================
  Files         449      449              
  Lines       48416    48452      +36     
==========================================
  Hits        12468    12468              
- Misses      34975    35011      +36     
  Partials      973      973              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants